mkarg commented on pull request #421:
URL: https://github.com/apache/maven/pull/421#issuecomment-752252406


   If the majority wants me to replace `default` in the interface by an actual 
implementation in `DefaultArtifact`, then I could solve it like this: Both 
`setField` and `getField` do store *both* variants in *two* internal fields, i. 
e. we have internally a `File` *and* a `Path`, so we spare the repeated 
conversion-on-read while only having an overhead of one additional reference. 
As typically read happens much more than write, this should speed up **both** 
code paths (the IO path and the NIO path) in an *optimal* way, as the getters 
always use the specific optimal field. That would satisfy @slachiewicz **and** 
take care of @rmannibucau's performance concerns. WDYT? Shall I change the PR 
in such a way? Votes please, as I like to get this done within this week.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to