mthmulders commented on a change in pull request #425:
URL: https://github.com/apache/maven/pull/425#discussion_r550858021
##########
File path:
maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java
##########
@@ -151,16 +151,16 @@ public void process( CliRequest cliRequest )
populateFromSettings( request, settingsResult.getEffectiveSettings() );
- if ( !settingsResult.getProblems().isEmpty() && logger.isWarnEnabled()
)
+ if ( !settingsResult.getProblems().isEmpty() && LOGGER.isWarnEnabled()
)
{
- logger.warn( "" );
- logger.warn( "Some problems were encountered while building the
effective settings" );
+ LOGGER.warn( "" );
+ LOGGER.warn( "Some problems were encountered while building the
effective settings" );
for ( SettingsProblem problem : settingsResult.getProblems() )
{
- logger.warn( "{} @ {}", problem.getMessage(),
problem.getLocation() );
+ LOGGER.warn( "{} @ {}", problem.getMessage(),
problem.getLocation() );
Review comment:
Shouldn't there be single quotes here, too, since the message and the
location are both non-numeric arguments?
##########
File path:
maven-core/src/main/java/org/apache/maven/project/collector/MultiModuleCollectionStrategy.java
##########
@@ -76,7 +76,7 @@ public MultiModuleCollectionStrategy( ModelLocator
modelLocator, ProjectsSelecto
}
else
{
- logger.debug( "Multi module project collection failed: {}"
+ LOGGER.debug( "Multi module project collection failed:{}"
Review comment:
Please restore the space after the colon.
##########
File path:
maven-core/src/main/java/org/apache/maven/project/collector/MultiModuleCollectionStrategy.java
##########
@@ -91,7 +91,7 @@ public MultiModuleCollectionStrategy( ModelLocator
modelLocator, ProjectsSelecto
if ( fallThrough )
{
- logger.debug( "Multi module project collection failed: {}"
+ LOGGER.debug( "Multi module project collection failed:{}"
Review comment:
Please restore the space after the colon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
