michael-o commented on a change in pull request #110:
URL: https://github.com/apache/maven-scm/pull/110#discussion_r552122460
##########
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
##########
@@ -96,11 +122,25 @@ public ScmResult executeCommand( ScmProviderRepository
repository, ScmFileSet fi
if ( versionOnly )
{
- return executeChangeLogCommand( repository, fileSet, version,
datePattern );
+ if ( limit == null )
+ {
+ return executeChangeLogCommand( repository, fileSet, version,
datePattern );
+ }
+ else
+ {
+ return executeChangeLogCommand( repository, fileSet, version,
datePattern, limit );
Review comment:
Why this if else pain? Why not pass a null and the short method call the
longer one? A concrete implementation can still throw an exception with a
non-null arg has been passed.
##########
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
##########
@@ -46,6 +46,15 @@ protected abstract ChangeLogScmResult
executeChangeLogCommand( ScmProviderReposi
String
datePattern )
throws ScmException;
+ @Deprecated
+ protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repository, ScmFileSet fileSet,
Review comment:
Correct. One should use the `ChangeLogScmRequest` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
