[
https://issues.apache.org/jira/browse/MRESOLVER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260430#comment-17260430
]
Michael Osipov commented on MRESOLVER-157:
------------------------------------------
I highly favorize this change. Willing to review a PR.
> Get rid of ServiceLocator in Resolver
> -------------------------------------
>
> Key: MRESOLVER-157
> URL: https://issues.apache.org/jira/browse/MRESOLVER-157
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamás Cservenák
> Priority: Major
>
> maven-resolver currently supports:
> * ServiceLocator
> * "vanilla" Guice (provides a module)
> * DI using SISU, as used in Maven
> IMO, it makes not much sense to support 3 vastly different "DI"s (in quotes
> as ServiceLocator is really just a dumb factory pattern).
> Not only just complicates the code base, makes changes error prone at least,
> yields for "exceptions" (this or that will never work with it, as seen with
> SyncContext), and, for me most importantly, prevents proper constructor
> initialization and validation of components.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)