cquoss commented on a change in pull request #110:
URL: https://github.com/apache/maven-scm/pull/110#discussion_r561282580
##########
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
##########
@@ -96,11 +122,25 @@ public ScmResult executeCommand( ScmProviderRepository
repository, ScmFileSet fi
if ( versionOnly )
{
- return executeChangeLogCommand( repository, fileSet, version,
datePattern );
+ if ( limit == null )
+ {
+ return executeChangeLogCommand( repository, fileSet, version,
datePattern );
+ }
+ else
+ {
+ return executeChangeLogCommand( repository, fileSet, version,
datePattern, limit );
Review comment:
OK. Will look into this and change it as requested.
##########
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
##########
@@ -46,6 +46,15 @@ protected abstract ChangeLogScmResult
executeChangeLogCommand( ScmProviderReposi
String
datePattern )
throws ScmException;
+ @Deprecated
+ protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repository, ScmFileSet fileSet,
Review comment:
Well, i come from a different angle here. I just want to get the limit
parameter to work. Because we have a use case for this. I am not here to
refactor this to use ChangeLogScmRequest. So i simply duplicated deprecated
methods to make it work. And yes - made them deprecated from the start so that
someone doing the refactoring part sees these also have to be taken into
account.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
