elharo commented on a change in pull request #6:
URL: 
https://github.com/apache/maven-dependency-tree/pull/6#discussion_r563399792



##########
File path: pom.xml
##########
@@ -173,7 +139,8 @@
               These files contains the expected output of this component and 
can not contain a license header.
             -->
             <exclude>src/it/*/expected*.txt</exclude>
-          </excludes>            
+            <exclude>src/it/**/*.iml</exclude>

Review comment:
       we should really .gitignore these

##########
File path: 
src/main/java/org/apache/maven/shared/dependency/graph/DependencyGraphBuilder.java
##########
@@ -26,7 +26,7 @@
 import java.util.Collection;
 
 /**
- * Maven project dependency graph builder API, neutral against Maven 2 or 
Maven 3.
+ * Maven project dependency graph builder API, based on Maven 3.1+.

Review comment:
       Wasn't this specifically the point of this API? i.e. to bridge between 2 
and 3? or was that a different artifact? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to