[
https://issues.apache.org/jira/browse/SUREFIRE-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271046#comment-17271046
]
Alexander Kriegisch commented on SUREFIRE-1788:
-----------------------------------------------
I just looked into your instructions, and it wouldtake so much longer for you
to answer my questions than do just do it yourself. Given your tight time
budget, that would not help you in any way. Some initial questions:
* What do you mean by "builder methods"? There is no builder pattern in class
{{StartupReportConfiguration}}.
* Do you maybe just mean something like returning something like {{new
NativeStdOutStreamConsumer(new PrintStreamLogger(originalSystemOut))}} from
those so-called builder methods?
* When extending the constructor of ForkedNodeArg, I would also add two fields
and getters, I guess. But then in {{SurefireForkChannel}} I could not easily
use those getters because {{getArguments()}} just returns an interface instance
{{ForkNodeArguments}}, not ForkedNodeArg. In order to pull that off I would
have to extend the interface and all implementing classes. Is that what you
want? Or should I check for {{instanceof ForkedNodeArg}} and then cast? Sounds
ugly.
I would really rather leave that change up to you, otherwise I might break more
than I would fix.
> Unhandled native logs in SurefireForkChannel
> --------------------------------------------
>
> Key: SUREFIRE-1788
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1788
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Failsafe Plugin, Maven Surefire Plugin, process
> forking
> Reporter: Tibor Digana
> Assignee: Tibor Digana
> Priority: Major
> Fix For: 3.0.0-M5
>
>
> This is related only to the internal change of the version 3.0.0-M5 itself.
> The
> [stdOut|https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/extensions/SurefireForkChannel.java#L153]
> should be printed to INFO on the console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
