michael-o commented on a change in pull request #87:
URL: 
https://github.com/apache/maven-integration-testing/pull/87#discussion_r565157126



##########
File path: 
core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
##########
@@ -106,6 +106,10 @@ public static Test suite()
         // Tests that don't run stable and need to be fixed
         // 
-------------------------------------------------------------------------------------------------------------
         // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- 
MNG-3137
+        suite.addTestSuite( 
MavenITmng4106InterpolationUsesDominantProfile400Test.class );

Review comment:
       Hmm, may ITs have an inline if for those cases. Why not use that style? 
It reduces the amount of code we have. Example: 
https://github.com/apache/maven-integration-testing/pull/96/files#diff-0323fd1cd7d6126ff8efaf53b1771bb88deb78c458141d38695979480c6710e5R58




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to