MartinKanters commented on a change in pull request #87:
URL:
https://github.com/apache/maven-integration-testing/pull/87#discussion_r565264028
##########
File path:
core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
##########
@@ -106,6 +106,10 @@ public static Test suite()
// Tests that don't run stable and need to be fixed
//
-------------------------------------------------------------------------------------------------------------
// suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); --
MNG-3137
+ suite.addTestSuite(
MavenITmng4106InterpolationUsesDominantProfile400Test.class );
Review comment:
My opinion is that those ifs can be useful in the tests when only a
single thing has to be changed per version.
In the classes that we have duplicated we noticed that we would have to
change the `.addCliOption` (which activates the profiles) everywhere and that
these tests already contained big `if (mvnVersion < 3) `-branches which tested
support for profiles.xml.
So in this case my preference is to duplicate the test class to keep the
tests readable and immutable (which was @rfscholte 's advice).
It does increase the amount of code + tests indeed, but I don't think that
outweighs the benefits listed above.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
