JanMosigItemis commented on pull request #83:
URL: https://github.com/apache/maven-shade-plugin/pull/83#issuecomment-769668875


   @rmannibucau yes I checked. It is bc 
org.apache.maven.plugins.shade.filter.MinijarFilter.removeServices(MavenProject,
 Clazzpath) calls `project.getRuntimeClasspathElements` which puts the output 
directory on the resulting list. See 
https://github.com/apache/maven/blob/bb916d0784c7631866167928e4d0615df3317567/maven-core/src/main/java/org/apache/maven/project/MavenProject.java#L412
   
   I could provide the test you wrote about, but I am not sure it leaves the 
scope of this PR, bc such a test was already missing before I started working 
on the issue. Please let me know if such a test is required here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to