cstamas commented on pull request #440: URL: https://github.com/apache/maven/pull/440#issuecomment-771897898
Looks good, and we did overlap a bit :) I pushed (not created PR) for "update for 1.70, minimal changes" and "update post 1.7.0, ie. 2.0.0 when we want to drop locator" https://github.com/apache/maven/compare/master...cstamas:for-170?expand=1 https://github.com/apache/maven/compare/master...cstamas:post-170?expand=1 For "post 1.7.0" IMO not only remove def ctor and init method, but injected things should be `final`... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
