michael-o commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r568875978
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/NoLockSyncContextFactory.java
##########
@@ -22,39 +22,42 @@
import java.util.Collection;
import javax.inject.Named;
+import javax.inject.Singleton;
import org.eclipse.aether.RepositorySystemSession;
import org.eclipse.aether.SyncContext;
import org.eclipse.aether.artifact.Artifact;
-import org.eclipse.aether.spi.synccontext.SyncContextFactory;
import org.eclipse.aether.metadata.Metadata;
/**
* A factory to create synchronization contexts. This default implementation
does not provide any real
* synchronization but merely completes the repository system.
*/
-@Named
-public class DefaultSyncContextFactory
- implements SyncContextFactory, org.eclipse.aether.impl.SyncContextFactory
+@Singleton
+@Named( NoLockSyncContextFactory.NAME )
+public class NoLockSyncContextFactory
Review comment:
That is absolutely correct, but shouldn't it remain for testing purposes
and proof that real code works?
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/NoLockSyncContextFactory.java
##########
@@ -22,39 +22,42 @@
import java.util.Collection;
import javax.inject.Named;
+import javax.inject.Singleton;
import org.eclipse.aether.RepositorySystemSession;
import org.eclipse.aether.SyncContext;
import org.eclipse.aether.artifact.Artifact;
-import org.eclipse.aether.spi.synccontext.SyncContextFactory;
import org.eclipse.aether.metadata.Metadata;
/**
* A factory to create synchronization contexts. This default implementation
does not provide any real
* synchronization but merely completes the repository system.
*/
-@Named
-public class DefaultSyncContextFactory
- implements SyncContextFactory, org.eclipse.aether.impl.SyncContextFactory
+@Singleton
+@Named( NoLockSyncContextFactory.NAME )
+public class NoLockSyncContextFactory
Review comment:
If you really want to drop, just do, but I think it has its usecases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
