sebthom commented on pull request #15: URL: https://github.com/apache/maven-filtering/pull/15#issuecomment-773855700
I pushed a change since apparently not only checked IOExceptions but also intenral runtime exceptions (e.g. IllegalArgumentExcpetion) are thrown since version 3.2.0 of the maven-resource-plugin when a filtered file has an unexpected encoding. Here is real world example. A submodule of a very large multi-artifact/module enterprise application. Without this PR it have would been very laborious (and maybe impossible for the average developer) to discover the root cause. Before this PR: ![image](https://user-images.githubusercontent.com/426959/107003705-7e2f2280-678d-11eb-9501-ed349360e00d.png) After this PR: ![image](https://user-images.githubusercontent.com/426959/107003594-563fbf00-678d-11eb-9aa4-9bdab1bfcb35.png) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org