slachiewicz commented on a change in pull request #2:
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/2#discussion_r571431033
##########
File path:
src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java
##########
@@ -944,12 +944,12 @@ private void fileWriteIfDiffers( DeferredFileOutputStream
outStream )
}
}
- private MavenFileFilterRequest setupRequest( File source, File file,
boolean isFiltering )
+ private MavenFileFilterRequest setupRequest( File source, File file )
{
MavenFileFilterRequest req = new MavenFileFilterRequest();
req.setFrom( source );
req.setTo( file );
- req.setFiltering( isFiltering );
+ req.setFiltering( true );
Review comment:
@rfscholte do we need more review here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
