elharo commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r578455690
##########
File path:
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##########
@@ -279,6 +332,20 @@ public boolean isStreaming()
private static final boolean SSL_ALLOW_ALL =
Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall",
"false" ) );
+ /**
+ * If enabled, then the content-type HTTP header will be set using the
file extension
+ * or the stream header to determine the type, <b>disabled by default</b>
+ */
+ private static final boolean AUTOSET_CONTENT_TYPE =
+ Boolean.valueOf( System.getProperty(
"maven.wagon.http.autocontenttype", "true" ) );
Review comment:
A lot of Maven code is 10+ years old and dates back to Java 1.4 and
earlier. It can be quite crufty, and consistency alone is not a string argument
in this context. The things we really care about are written down in the docs.
Everything else should assume best current practices for Java 1.7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
