hboutemy edited a comment on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786778197
> It would be worth for future maintenance to create a new class checking these characters in profile id because both classes DefaultModelValidator and MavenCli are chcecking the first (and second character ?) character, so it would worth to change the algorithm in one place instead of two. I understand the general idea, but IMHO, this would create more complexity (with dependency tree between artifacts, and abstraction) than real benefit. But don't hesitate to work on this later if you really think there is a benefit ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
