Syquel commented on a change in pull request #12:
URL: https://github.com/apache/maven-gpg-plugin/pull/12#discussion_r583937880
##########
File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java
##########
@@ -48,4 +50,22 @@ public void testOpposite()
assertFalse( GpgVersion.parse( "gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)" )
.isBefore( GpgVersion.parse( "2.0.26" ) ) );
}
+
+ @Test
+ public void testEquality()
+ {
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ),
GpgVersion.parse( "gpg (GnuPG) 2.2.1" ) );
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ),
GpgVersion.parse( "2.2.1" ) );
+ assertEquals( GpgVersion.parse( "gpg (GnuPG/MacGPG2) 2.2.10" ),
GpgVersion.parse( "2.2.10" ) );
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)"
), GpgVersion.parse( "2.0.26" ) );
+
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).hashCode(),
GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).hashCode() );
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).hashCode(),
GpgVersion.parse( "2.2.1" ).hashCode() );
+ assertEquals( GpgVersion.parse( "gpg (GnuPG/MacGPG2) 2.2.10"
).hashCode(), GpgVersion.parse( "2.2.10" ).hashCode() );
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)"
).hashCode(), GpgVersion.parse( "2.0.26" ).hashCode() );
+
+ assertNotEquals( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ),
GpgVersion.parse( "2.2.0" ) );
Review comment:
I added test statements to assert that the hash codes are different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
