gnodet commented on pull request #442: URL: https://github.com/apache/maven/pull/442#issuecomment-797725461
> This is the next I want to fix. I do understand the cause: before the commit both filemodel and raw model where part of phase 1, now raw model has moved to phase 2. This is also where the build/consumer builds up the context, so it can be re-used during distribution. So yes, these must become ConcurrentHashMaps. > @gnodet I would expect ConcurrentHashMaps to be enough, why the need for the extra layer of `Holder`? @rfscholte the reason is explain at https://issues.apache.org/jira/browse/MNG-7111, it can cause deadlocks... The holder makes the usage of the concurrent hash map safe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
