elharo commented on a change in pull request #347:
URL: https://github.com/apache/maven/pull/347#discussion_r600741378
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -255,12 +263,20 @@ public DefaultModelBuilder setReportingConverter(
ReportingConverter reportingCo
return this;
}
+ public DefaultModelBuilder setProfileActivationFilePathInterpolator(
+ ProfileActivationFilePathInterpolator
profileActivationFilePathInterpolator )
+ {
+ this.profileActivationFilePathInterpolator =
profileActivationFilePathInterpolator;
+ return this;
+ }
+
@Override
public DefaultTransformerContextBuilder newTransformerContextBuilder()
{
return new DefaultTransformerContextBuilder();
}
-
+
+ @SuppressWarnings( "checkstyle:methodlength" )
Review comment:
Why is this needed. This is only a 4 line method as far as I can tell.
##########
File path:
maven-model-builder/src/test/java/org/apache/maven/model/profile/activation/FileProfileActivatorTest.java
##########
@@ -0,0 +1,153 @@
+package org.apache.maven.model.profile.activation;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.model.Activation;
+import org.apache.maven.model.ActivationFile;
+import org.apache.maven.model.Profile;
+import org.apache.maven.model.path.DefaultPathTranslator;
+import org.apache.maven.model.path.ProfileActivationFilePathInterpolator;
+import org.apache.maven.model.profile.DefaultProfileActivationContext;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.io.IOException;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/**
+ * Tests {@link FileProfileActivator}.
+ *
+ * @author Ravil Galeyev
+ */
+public class FileProfileActivatorTest extends
AbstractProfileActivatorTest<FileProfileActivator>
+{
+ private static final String PATH = "src/test/resources/";
Review comment:
This might better fit in a temp directory instead of the current working
directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]