Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605548725
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1568,13 +1572,13 @@ private void convertGroupParameters()
private void convertJunitEngineParameters()
{
- if ( this.getJunitIncludeEngine() != null )
+ if ( StringUtils.isNotBlank( getJunitIncludeEngine()) )
Review comment:
After you removed the Line 65, you can simply type:
`if ( isNotBlank( getJunitIncludeEngine() ) )`
notice that I added a white space between the end-brackets to confirm the
checkstyle rule.
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1568,13 +1572,13 @@ private void convertGroupParameters()
private void convertJunitEngineParameters()
{
- if ( this.getJunitIncludeEngine() != null )
+ if ( StringUtils.isNotBlank( getJunitIncludeEngine()) )
{
- getProperties().setProperty(
ProviderParameterNames.JUNIT_INCLUDE_ENGINE_PROP, this.getJunitIncludeEngine()
);
+ getProperties().setProperty( JUNIT_INCLUDE_ENGINE_PROP,
getJunitIncludeEngine() );
}
- if ( this.getJunitExcludeEngine() != null )
+ if ( StringUtils.isNotBlank( getJunitExcludeEngine()) )
Review comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
