adam11grafik commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r607843333



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -501,6 +504,12 @@
     @Parameter( property = "excludedGroups" )
     private String excludedGroups;
 
+    @Parameter( property = "junitIncludeEngine" )

Review comment:
       Hi, I made most of changes but there is conversion of String[] to String 
which does not look so good but I need this to pass values to properties.
   Regarding that include and exclude engines should be provided in array I 
agree but please, remember that most of usage of this feature will base 
probably on use of one value only as junit as default have only one engine (one 
for JUnit5 and one for JUnit Vintage).
   I will push my changes in next minutes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to