cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r611909927
########## File path: maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/NamedLockSupport.java ########## @@ -0,0 +1,87 @@ +package org.eclipse.aether.named.support; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.concurrent.atomic.AtomicInteger; + +import org.eclipse.aether.named.NamedLock; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Support class for {@link NamedLock} implementations providing reference counting. + */ +public abstract class NamedLockSupport + implements NamedLock +{ + protected final Logger log = LoggerFactory.getLogger( getClass() ); + + private final String name; + + private final NamedLockFactorySupport factory; + + private final AtomicInteger refCount; + + public NamedLockSupport( final String name, final NamedLockFactorySupport factory ) + { + this.name = name; + this.factory = factory; + this.refCount = new AtomicInteger( 0 ); + } + + public int incRef() + { + return refCount.incrementAndGet(); + } + + public int decRef() + { + return refCount.decrementAndGet(); + } Review comment: moved ref counting to factory, lock itself is unaware of it, see a1d5966e3ede80fc28a22675d2657723f1a061eb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
