[ 
https://issues.apache.org/jira/browse/MSHADE-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324446#comment-17324446
 ] 

Robert Scholte commented on MSHADE-382:
---------------------------------------

bq. The better alternative is to convince the team in the upstream parent to 
change the shading configuration so that it becomes optional or its added via 
profiles.

I want to help you with this. If you can describe in which cases you don't want 
shading, I will help in finding a proper solution for the micronaut team.

To me the general skip parameter is overrated and an anti-pattern which 
indicates theres a problem somewhere else. It is a cheap way you must program 
as code in the plugin, which is also a sign there's something wrong (and with 
that it has become the #1 excuse why plugins need it: a lot of other plugins 
have it too). 
In case parameters are added, I want to be sure of its value because it will be 
very hard to remove parameters.

> Add an option to skip execution
> -------------------------------
>
>                 Key: MSHADE-382
>                 URL: https://issues.apache.org/jira/browse/MSHADE-382
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.2.4
>            Reporter: Andres Almiray
>            Priority: Major
>
> It'd be great to have a property for skipping execution, such as 
> `maven.shade.skip`. Useful when a parent has setup shading but a child would 
> like to skip it for example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to