mkarg commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-826277638
@rmannibucau I don't get that - your vote on Github still is +1 for this PR. So why didn't you change it to -1 clearly requesting the change Robert proposed? About your side note, this is unrealistic. *Any* change of *any* POM will break a build, and in reality least people like to put tests *ontop* that check that the POM itself wasn't incorrect. The POM *is* the single source of truth, so it *must* be relied upon, hence it *must never* be temporarily fiddled with. Adding such constraints intop to proof the consistency of the POM make the POM simply bloated and unreadable, cost a lot of additional development time, and are everything but CoC anymore. What users of Maven expect is smallest possible POMs and allowing to temporarily override POM settings at the command line, without chaning POMs all the time. This might not what you like to hear, but it is what the average Joe simply does and expects from this tool. That is why I think, we should listen more carefully to users instead of always concentrating on the inner circle's opinions. Having said that, if the majority has such big trouble with our PR, maybe it is best if Andres and me simply change it, even if we disagree/dislike, just to have *any* progress here. But really, this makes me totally doubt about the way this community applies votes... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
