Tibor17 edited a comment on pull request #349:
URL: https://github.com/apache/maven-surefire/pull/349#issuecomment-828669027


   @laeubi 
   I think the message is not a root cause. It is also a problem but it is not 
root cause. The problem is that `failIfNoTests` is not set to `false` by 
default, and it should be! If it was set to `false`, the method 
`getEffectiveFailIfNoTests` would return false for existing tests. For 
non-existing tests where the `failIfNoSpecifiedTests` should be set to `true` 
by default (currently null - bad) should also return `false`. But the problem 
is that these two `false` have different meaning and therefore this method 
should return an enum with one successful return and two negative returns for 
errors. Then I would agree with you @laeubi that the message should be more 
meaningful but upon the enum values.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to