tbroyer commented on a change in pull request #40:
URL:
https://github.com/apache/maven-compiler-plugin/pull/40#discussion_r630410255
##########
File path:
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
##########
@@ -1660,26 +1660,27 @@ private boolean hasNewFile( File classPathEntry, Date
buildStartTime )
requiredArtifacts.add( artifact );
}
- ArtifactResolutionRequest request = new ArtifactResolutionRequest()
- .setArtifact( requiredArtifacts.iterator().next() )
- .setResolveRoot( true )
- .setResolveTransitively( true )
- .setArtifactDependencies( requiredArtifacts )
- .setLocalRepository( session.getLocalRepository() )
- .setRemoteRepositories(
project.getRemoteArtifactRepositories() );
+ Set<String> elements = new HashSet<>( );
- ArtifactResolutionResult resolutionResult =
repositorySystem.resolve( request );
+ for ( Artifact artifact : requiredArtifacts )
+ {
+ ArtifactResolutionRequest request = new
ArtifactResolutionRequest()
+ .setArtifact( artifact )
+ .setResolveRoot( true )
+ .setResolveTransitively( true )
+ .setLocalRepository(
session.getLocalRepository() )
+ .setRemoteRepositories(
project.getRemoteArtifactRepositories() );
- resolutionErrorHandler.throwErrors( request, resolutionResult );
+ ArtifactResolutionResult resolutionResult =
repositorySystem.resolve( request );
Review comment:
There should probably be a single call to `resolve` with some synthetic
artifact that depends on all the `requiredArtifacts`, such that dependency
mediation can take place (e.g. two processors or compiler plugins have a
dependency on Guava on different versions; you'll want a single Guava JAR in
the processor path)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
