laeubi commented on a change in pull request #350:
URL: https://github.com/apache/maven-surefire/pull/350#discussion_r630717850
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -4215,4 +4213,14 @@ private Classpath setCachedClasspath( @Nonnull String
key, @Nonnull Set<Artifact
return classpath;
}
}
+
+ /**
+ * No tests run failures.
+ */
+ enum NoTestsFailureReason
Review comment:
Maybe it is better to get away from all this "NOs" I think
"TestRunExpectation" or something similar might be better here ...
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -4215,4 +4213,14 @@ private Classpath setCachedClasspath( @Nonnull String
key, @Nonnull Set<Artifact
return classpath;
}
}
+
+ /**
+ * No tests run failures.
+ */
+ enum NoTestsFailureReason
+ {
+ NO_FAILURE,
+ NO_SPECIFIED_TESTS_RUN,
Review comment:
... SPECIFIED_TESTS_RUN here...
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -4215,4 +4213,14 @@ private Classpath setCachedClasspath( @Nonnull String
key, @Nonnull Set<Artifact
return classpath;
}
}
+
+ /**
+ * No tests run failures.
+ */
+ enum NoTestsFailureReason
+ {
+ NO_FAILURE,
Review comment:
and then "NONE" here ...
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -4215,4 +4213,14 @@ private Classpath setCachedClasspath( @Nonnull String
key, @Nonnull Set<Artifact
return classpath;
}
}
+
+ /**
+ * No tests run failures.
+ */
+ enum NoTestsFailureReason
+ {
+ NO_FAILURE,
+ NO_SPECIFIED_TESTS_RUN,
+ NO_TESTS_RUN,
Review comment:
... and finally "ANY_TESTS_RUN" or "ATLAEST_ONE_TEST" here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
