MartinKanters commented on pull request #1: URL: https://github.com/apache/maven-docck-plugin/pull/1#issuecomment-841091744
Thanks @timtebeek for the extra warning. Preemptive authentication are things I did not know about yet, so before merging I wanted to make sure that nothing would break. I've tested the 1.1 build and yours against a local proxy with authentication to check the differences. My test target was the maven-help-plugin. Both showed the following warnings in the logs per host: ``` May 14, 2021 9:43:58 AM org.apache.commons.httpclient.HttpMethodDirector authenticateHost WARNING: Required credentials not available for BASIC <any realm>@www.apache.org:443 May 14, 2021 9:43:58 AM org.apache.commons.httpclient.HttpMethodDirector authenticateHost WARNING: Preemptive authentication requested but no default credentials available ``` The authentication however works fine in the end, and since there is no functional regression between the two, I'm going ahead and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
