Tibor17 commented on a change in pull request #350:
URL: https://github.com/apache/maven-surefire/pull/350#discussion_r632795790
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -4215,4 +4213,14 @@ private Classpath setCachedClasspath( @Nonnull String
key, @Nonnull Set<Artifact
return classpath;
}
}
+
+ /**
+ * No tests run failures.
+ */
+ enum NoTestsFailureReason
Review comment:
Pls check the names of enum now, see the
[commit](https://github.com/apache/maven-surefire/pull/350/commits/3e8c22489648e06a520771c5b857088bad0e565b).
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -4215,4 +4213,14 @@ private Classpath setCachedClasspath( @Nonnull String
key, @Nonnull Set<Artifact
return classpath;
}
}
+
+ /**
+ * No tests run failures.
+ */
+ enum NoTestsFailureReason
+ {
+ NO_FAILURE,
Review comment:
Pls check the names of enum now, see the
[commit](https://github.com/apache/maven-surefire/pull/350/commits/3e8c22489648e06a520771c5b857088bad0e565b).
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -4215,4 +4213,14 @@ private Classpath setCachedClasspath( @Nonnull String
key, @Nonnull Set<Artifact
return classpath;
}
}
+
+ /**
+ * No tests run failures.
+ */
+ enum NoTestsFailureReason
+ {
+ NO_FAILURE,
+ NO_SPECIFIED_TESTS_RUN,
Review comment:
Pls check the names of enum now, see the
[commit](https://github.com/apache/maven-surefire/pull/350/commits/3e8c22489648e06a520771c5b857088bad0e565b).
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -4215,4 +4213,14 @@ private Classpath setCachedClasspath( @Nonnull String
key, @Nonnull Set<Artifact
return classpath;
}
}
+
+ /**
+ * No tests run failures.
+ */
+ enum NoTestsFailureReason
+ {
+ NO_FAILURE,
+ NO_SPECIFIED_TESTS_RUN,
+ NO_TESTS_RUN,
Review comment:
Pls check the names of enum now, see the
[commit](https://github.com/apache/maven-surefire/pull/350/commits/3e8c22489648e06a520771c5b857088bad0e565b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
