rfscholte commented on a change in pull request #90:
URL: https://github.com/apache/maven-shade-plugin/pull/90#discussion_r633064165
##########
File path: src/test/java/org/apache/maven/plugins/shade/mojo/ShadeMojoTest.java
##########
@@ -62,6 +62,43 @@
public class ShadeMojoTest
extends PlexusTestCase
{
+ public void testSkipShading() throws Exception
+ {
+ final ShadeMojo mojo = new ShadeMojo();
Review comment:
This is not a not a PlexusTest, but a unittest using reflection. And I
understand it follows other test examples, but this keeps increasing the
technical dept.
I suggest to drop this as the non-default value is already covered by the
integration test, the default value with all the other tests.
##########
File path: src/it/projects/MSHADE-382_skip_execution/verify.bsh
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import java.io.*;
+
+File originalJarFile = new File( basedir,
"target/original-skip-execution-1.0.jar" );
Review comment:
Groovy is the standard nowadays, which would probably make this a
oneliner, something like:
`assert !(new File( basedir, "target/original-skip-execution-1.0.jar"
).exists())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
