[GitHub] [maven-surefire] andpab commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs

[GitBox]

andpab commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r633899244



##########
File path: 
surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
##########
@@ -395,28 +396,46 @@ public void testJupiterEngineWithDisplayNames()
                 .assertContainsText( "<< ✨ >>" );
 
         validator.getSurefireReportsFile( 
"junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
-                .assertContainsText( "73$71 ✔" );
-
-        validator.getSurefireReportsFile( 
"junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
-                .assertContainsText( "73$72 ✔" );
+                .assertContainsText( "73$71 ✔" )
+                .assertContainsText( "73$72 ✔" )
+                .assertContainsText( "73$73 ✔" )
+                .assertContainsText( "73$74 ✔" );
 
 
         validator.getSurefireReportsFile( 
"TEST-junitplatformenginejupiter.DisplayNameTest.xml", UTF_8 )
                 .assertContainsText( "testcase name=\"73$71 ✔\" 
classname=\"&lt;&lt; ✨ &gt;&gt;\"" )
                 .assertContainsText( "testcase name=\"73$72 ✔\" 
classname=\"&lt;&lt; ✨ &gt;&gt;\"" )
+                .assertContainsText( "testcase name=\"73$73 ✔ [1] a\" 
classname=\"&lt;&lt; ✨ &gt;&gt;\"" )
+                .assertContainsText( "testcase name=\"73$73 ✔ [2] b\" 
classname=\"&lt;&lt; ✨ &gt;&gt;\"" )
+                .assertContainsText( "testcase name=\"73$73 ✔ [3] c\" 
classname=\"&lt;&lt; ✨ &gt;&gt;\"" )
+                .assertContainsText( "testcase name=\"73$74 ✔ [1] a\" 
classname=\"&lt;&lt; ✨ &gt;&gt;\"" )
+                .assertContainsText( "testcase name=\"73$74 ✔ [2] b\" 
classname=\"&lt;&lt; ✨ &gt;&gt;\"" )
+                .assertContainsText( "testcase name=\"73$74 ✔ [3] c\" 
classname=\"&lt;&lt; ✨ &gt;&gt;\"" )
                 .assertContainsText( XML_TESTSUITE_FRAGMENT );
 
 
         validator.getSurefireReportsFile( 
"TEST-junitplatformenginejupiter.BasicJupiterTest.xml", UTF_8 )
                 .assertContainsText( "<testcase name=\"test(TestInfo)\" "
                         + 
"classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
-                .assertContainsText( "<testcase name=\"0 + 1 = 1\" "
+                .assertContainsText( "<testcase name=\"add(int, int, int)[1] 0 
+ 1 = 1\" "
+                        + 
"classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+                .assertContainsText( "<testcase name=\"add(int, int, int)[2] 1 
+ 2 = 3\" "
+                        + 
"classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+                .assertContainsText( "<testcase name=\"add(int, int, int)[3] 
49 + 51 = 100\" "
+                        + 
"classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+                .assertContainsText( "<testcase name=\"add(int, int, int)[4] 1 
+ 100 = 101\" "
+                        + 
"classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+                .assertContainsText( "<testcase name=\"square(int, int)[1] 1, 
1\" "
+                        + 
"classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+                .assertContainsText( "<testcase name=\"square(int, int)[2] 2, 
4\" "
+                        + 
"classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+                .assertContainsText( "<testcase name=\"square(int, int)[3] 3, 
9\" "
                         + 
"classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
-                .assertContainsText( "<testcase name=\"1 + 2 = 3\" "

Review comment:
       Rewrote it, so that only a new dedicated test project and IT for it is 
added.
   
   Test project:    surefire-1914-xml-reporting-parameterizedtest
   IT:    Surefire1914XmlReportingParameterizedTestIT.java
   
   Please have a look again.
   
   For reference: The relevant pre-existing IT with a divergent expectation is 
JUnitPlatformEnginesIT#testJupiterEngineWithDisplayNames




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org