gnodet commented on pull request #473:
URL: https://github.com/apache/maven/pull/473#issuecomment-844864096


   > > @MartinKanters it seems to work. I've forced pushed the change.
   > 
   > Nice, I definitely prefer defaulting to the old width. I see that you are 
not targeting any customized ITs and removed the changes in the unit tests. To 
me that proves that it's backwards compatible for non-ansi terminals.
   > And now that we have a constructor where we can put in the values, we can 
create some unit tests which verify that the terminal width is set correctly in 
all scenarios. I'm sorry that I'm asking for more changes on a PR that 
@mthmulders and I initially delivered... :)
   
   I've added a test to check various terminal widths.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to