cstamas commented on a change in pull request #91:
URL: https://github.com/apache/maven-shade-plugin/pull/91#discussion_r636313518
##########
File path: src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
##########
@@ -651,14 +641,13 @@ private void setupHintedShader()
{
if ( shaderHint != null )
{
- try
- {
- shader = (Shader) plexusContainer.lookup( Shader.ROLE,
shaderHint );
- }
- catch ( ComponentLookupException e )
+ shader = shaders.get( shaderHint );
+
+ if ( shader == null )
{
- throw new MojoExecutionException( "unable to lookup own Shader
implementation with hint:'" + shaderHint
- + "'", e );
+ throw new MojoExecutionException(
+ "unable to lookup own Shader implementation with hint:'" +
shaderHint + "'"
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
