cstamas commented on pull request #93: URL: https://github.com/apache/maven-shade-plugin/pull/93#issuecomment-845689454
So, as I assumed: it is OS newline vs Java `\n`. But, the good news is that ONLY TWO classes in this project are affected by it (uses `System.getProperty( "line.separator" )`): * the MavenJDOMWriter * and the ServiceResourceTransformerTest UT that failed on CI. This is wrong IMO, as https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html tells about file encoding, but IMO line ending of `\n` for it (on any plaf) is acceptable. All the rest of code use `\n`. UT is really unimportant (will align it with this PR), but unsure why MavenJDOMWriter uses OS newline, when IMHO it should be either using "edited POM" lineending or universal `\n`. @elharo @michael-o any opinion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
