kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637097894
##########
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##########
@@ -694,6 +702,11 @@ private void addResource( Set<String> resources,
JarOutputStream jos, String nam
List<Relocator> relocators;
+ // Use thread-local, just in case 'map*' calls are ever done
concurrently. Make sure that the using class
+ // initialises this value according to its needs, usually setting the
value to false per file before starting
+ // relocation.
+ ThreadLocal<Boolean> wasRelocated = new ThreadLocal<>();
Review comment:
I didn't say or mean, you didn't review it. You obviously did. I was not
sure if you checked out the branch and watched what it does and compared to
what it did before. If you did, fine. Then you know the byte code comparison
doesn't cut it. Possibly your other idea does. I never understood this cryptic
way of nesting and delegating readers, writers, visitors and remappers in ASM.
So this is me being inexperienced in that field or maybe also being not smart
enough or not conditioned on this kind of usage pattern. But I do promise to
try and understand what you mean tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
