qualitesys commented on a change in pull request #61:
URL: https://github.com/apache/maven-doxia/pull/61#discussion_r642046393



##########
File path: 
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java
##########
@@ -1658,6 +1659,35 @@ public void tableHeaderCell( SinkEventAttributes 
attributes )
     private void tableCell( boolean headerRow, MutableAttributeSet attributes )
     {
         Tag t = ( headerRow ? HtmlMarkup.TH : HtmlMarkup.TD );
+        
+        if (   !headerRow 
+            && null != this.cellCountStack

Review comment:
       Starting with constants in logical expressions prevents from a very 
common mistakes that can be very tricky, this concerns Java, C, C++, C# att 
least.
   
   See [https://cwe.mitre.org/data/definitions/481.html](url)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to