[
https://issues.apache.org/jira/browse/MDEP-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365649#comment-17365649
]
Elliotte Rusty Harold commented on MDEP-753:
--------------------------------------------
Just an educated guess but this might be the problem:
{{ private Set<Artifact> getTestArtifactsWithNonTestScope( Set<Artifact>
testOnlyArtifacts )
{
Set<Artifact> nonTestScopeArtifacts = new LinkedHashSet<>();
for ( Artifact artifact : testOnlyArtifacts )
{
if ( artifact.getScope().equals( "compile" ) )
{
nonTestScopeArtifacts.add( artifact );
}
}
return nonTestScopeArtifacts;
}}}
In particular is it possible that artifact.getScope().equals( "compile" )
misses cases where the scope is null or empty?
> Non-test dependency reported as Non-test scoped test only dependency
> --------------------------------------------------------------------
>
> Key: MDEP-753
> URL: https://issues.apache.org/jira/browse/MDEP-753
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze
> Reporter: Elliotte Rusty Harold
> Priority: Minor
>
> Saw this when updating the google-http-java-client from 3.1.2 to 3.2.0 of the
> plugin. I'm not immediately sure whether this is a regression:
> [INFO] --- maven-dependency-plugin:3.2.0:analyze (default-cli) @
> google-http-client ---
> Warning: Non-test scoped test only dependencies found:
> Warning: com.google.guava:guava:jar:30.1.1-android:compile
> Warning: io.opencensus:opencensus-api:jar:0.28.0:compile
> Changing Guava to scope test breaks the build, which is expected based on the
> code. The warning seems incorrect.
> https://github.com/googleapis/google-http-java-client/pull/1396
> https://github.com/googleapis/google-http-java-client/pull/1396/checks?check_run_id=2809438131
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
