kriegaex commented on pull request #83:
URL: https://github.com/apache/maven-shade-plugin/pull/83#issuecomment-873338678


   @JanMosigItemis, maybe you want to reconsider your opinion and simplify the 
PR the way I suggested. I guess, the smaller the change, the less nested the 
control structures, the fewer new imports you pull in without any obvious 
benefit, the higher the chances that someone merges this quickly. You may also 
want to minimise your test fix and factor out the actual test refactoring into 
either a new PR or at least into a separate commit, so we can clearly 
differentiate the fix from the refactoring. It helps nobody if the PR is just 
sitting here, rotting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to