kriegaex edited a comment on pull request #83: URL: https://github.com/apache/maven-shade-plugin/pull/83#issuecomment-873350704
> Code refactoring is always a trade-off. I was taught to avoid nesting control structures as much as reasonably possible. Actually, this could all be factored out into smaller methods, each of which would be more readable. I just did that on top of your PR, factoring out the big method into 3 smaller ones. I kept the pattern to use `continue`, though - sorry. I also refactored your tests into one, because they were 90% duplicates, also renaming the test method from `this_naming_pattern` to `thatNamingPattern` like in the rest of the test class (and also according to Java standards). I also reordered the imports so as to minimise changes compared to the main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
