elharo commented on a change in pull request #35:
URL: https://github.com/apache/maven-archetype/pull/35#discussion_r663355446
##########
File path:
archetype-common/src/main/java/org/apache/maven/archetype/common/util/PomUtils.java
##########
@@ -79,6 +83,13 @@ public static boolean addNewModule( String artifactId,
Reader fileReader, Writer
dbf.setXIncludeAware( false );
dbf.setExpandEntityReferences( false );
+ InputStream inputStream =
PomUtils.class.getClassLoader().getResourceAsStream( "maven-4.0.0.xsd" );
Review comment:
What is the purpose of loading this schema?
##########
File path:
archetype-common/src/test/java/org/apache/maven/archetype/old/ArchetypeTest.java
##########
@@ -239,92 +242,152 @@ private ClassLoader getContextClassloader( Artifact
archetypeArtifact, ArtifactR
return archetypeJarLoader;
}
- public void testAddModuleToParentPOM()
- throws Exception
+ public void testAddModuleToParentBasic()
+ throws Exception
{
- String pom = "<project>\n"
- + " <packaging>pom</packaging>\n"
- + "</project>";
+ String pom = ("<project " +
Review comment:
This is a good fix, but does not appear related to the description of
this PR
##########
File path: archetype-common/src/main/resources/maven-4.0.0.xsd
##########
@@ -0,0 +1,2246 @@
+<?xml version="1.0"?>
Review comment:
strange that this has to be copied into this project. I'd expect it to
be loaded from maven core, if at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
