kriegaex edited a comment on pull request #355:
URL: https://github.com/apache/maven-surefire/pull/355#issuecomment-874045506
Of course you know better than me, which is why I sent my RFC about the open
issue (zombie Java processes) in the first place. Now you finally have
acknowledged that there actually **is** a problem. Before you
* falsely claimed multiple times that this PR did not contain your
previous bugfix,
* called the back-ported reproducer test case in the other branch
"irrelevant",
* did not explicitly acknowledge that the zombie processes are a problem
you are going to fix (just acknowledged it now in your most recent 2 comments -
thanks for that),
* for no good reason copied my commits instead of merging this PR.
Those things I was complaining and explaining about. Had you just
acknowledged the problem before and somehow signalled that you are intending to
fix them, either here or in a new issue/PR, it would have been fine.
> `<forkedProcessTimeoutInSeconds>15</forkedProcessTimeoutInSeconds>`
Well, that is nowhere to be found in your commits. Besides, I tried that
before, both in the IT module settings and in the IT POMs themselves. I also
tried the timeout in the IT tests themselves, all to no avail. If you see ways
to improve this, I will be glad.
BTW, would you please be so kind as to revert your commit (or force-push the
previous HEAD) and merge this PR instead? You created your commit under the
false notion of my PR not being forked off of master. I really would like to
see my own commits here as a small recognition of my contribution. I spent lots
of time, trying to explain this PR to you. Of course, I can adjust my PR to be
like yours, i.e. a single project with both Surefire and Failsafe settings all
in one. If you had told me to do it like that in a normal code review, I would
have done so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
