michael-o commented on a change in pull request #489:
URL: https://github.com/apache/maven/pull/489#discussion_r672601880
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -814,7 +814,7 @@ private Model readRawModel( ModelBuildingRequest request,
DefaultModelProblemCol
}
catch ( IOException e )
{
- problems.add( new ModelProblemCollectorRequest(
Severity.FATAL, Version.V37 ).setException( e ) );
Review comment:
Very good catch. Is `V37` still used somewhere else?
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -70,7 +70,7 @@
implements ModelValidator
{
- private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile(
"\\$\\{(.+?)\\}" );
+ private static final Pattern EXPRESSION_NAME = Pattern.compile(
"\\$\\{(.+?)\\}" );
Review comment:
I think the new var name does not make sense since it does not contain
the name of th expression, but the espression itself.
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -814,7 +814,7 @@ private Model readRawModel( ModelBuildingRequest request,
DefaultModelProblemCol
}
catch ( IOException e )
{
- problems.add( new ModelProblemCollectorRequest(
Severity.FATAL, Version.V37 ).setException( e ) );
Review comment:
There is no when this is merged.
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -814,7 +814,7 @@ private Model readRawModel( ModelBuildingRequest request,
DefaultModelProblemCol
}
catch ( IOException e )
{
- problems.add( new ModelProblemCollectorRequest(
Severity.FATAL, Version.V37 ).setException( e ) );
Review comment:
There is none when this is merged.
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -70,7 +70,7 @@
implements ModelValidator
{
- private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile(
"\\$\\{(.+?)\\}" );
+ private static final Pattern EXPRESSION_NAME = Pattern.compile(
"\\$\\{(.+?)\\}" );
Review comment:
You are right, `EXPRESSION_NAME_PATTERN`? I wonder why it was called
`CI_FRIENDLY_EXPRESSION`.
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -70,7 +70,7 @@
implements ModelValidator
{
- private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile(
"\\$\\{(.+?)\\}" );
+ private static final Pattern EXPRESSION_NAME = Pattern.compile(
"\\$\\{(.+?)\\}" );
Review comment:
Accepted and makes sense
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -762,15 +762,28 @@ private void validateRawRepositories(
ModelProblemCollector problems, List<Repos
String prefix2, ModelBuildingRequest
request )
{
Map<String, Repository> index = new HashMap<>();
-
+
Review comment:
Please drop the trailing whitespace here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
