gnodet commented on a change in pull request #486:
URL: https://github.com/apache/maven/pull/486#discussion_r674625338
##########
File path:
maven-model-transform/src/test/java/org/apache/maven/model/transform/ConsumerPomXMLFilterTest.java
##########
@@ -82,10 +69,9 @@ protected AbstractSAXFilter getFilter(
Consumer<LexicalHandler> lexicalHandlerCo
};
- RawToConsumerPomXMLFilter filter =
- new RawToConsumerPomXMLFilterFactory( buildPomXMLFilterFactory
).get( Paths.get( "pom.xml" ) );
- filter.setFeature( "http://xml.org/sax/features/namespaces";, true );
- return filter;
+ parser = new RawToConsumerPomXMLFilterFactory(
buildPomXMLFilterFactory )
+ .get( parser, Paths.get( "pom.xml" ) );
+ return parser;
Review comment:
I really don't get the problem, but once again, I've added an
intermediary variable.
Some people also prefer not returning instances created directly to ease
debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
