michael-o commented on a change in pull request #518:
URL: https://github.com/apache/maven/pull/518#discussion_r680501659
##########
File path: apache-maven/src/assembly/shared/run
##########
@@ -14,6 +14,7 @@ exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "${LAUNCHER_JAR}" \
- $MAVENHOME_CONFIG \
+ "-Dclassworlds.conf=$CLASSWOLRDS_CONF" \
Review comment:
Thanks, will fix that.
We cannot add the system property name to the variable value because a
subsequent ticket will handle the Cygwin path conversion between Unix and
Windows. This is not covered for the moment. If you look at `sh -x mvn ...`
you'll see that still the Unix path is passed and we rely on implicit Cygwin
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
