rmannibucau commented on a change in pull request #4:
URL: 
https://github.com/apache/maven-scripting-plugin/pull/4#discussion_r684363382



##########
File path: src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java
##########
@@ -73,8 +84,10 @@ public void execute()
          AbstractScriptEvaluator execute = constructExecute();
 
          Bindings bindings = new SimpleBindings();
+         bindings.put( "session", session );
          bindings.put( "project", project );
          bindings.put( "log", getLog() );
+         bindings.put( "servers", new Servers( session, settingsDecrypter ) );

Review comment:
       What I want is a Server#password in clear but I don't want to decipher 
all servers upfront. From what I saw, getSettings() is NOT clear there so I 
would have to "clearify" it before binding it which I want to avoid so I 
thought using a lazy simple accessor is more script friendly than exposing the 
session and letting user use plexus container to do lookups to decipher values.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to