rfscholte commented on a change in pull request #33:
URL: https://github.com/apache/maven-plugin-tools/pull/33#discussion_r685091408
##########
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
##########
@@ -316,13 +307,13 @@ private PluginDescriptor extractPluginDescriptor()
try
{
- List<ComponentDependency> deps =
GeneratorUtils.toComponentDependencies( project.getRuntimeDependencies() );
+ List<ComponentDependency> deps =
GeneratorUtils.toComponentDependencies( project.getArtifacts() );
pluginDescriptor.setDependencies( deps );
PluginToolsRequest request = new DefaultPluginToolsRequest(
project, pluginDescriptor );
request.setEncoding( encoding );
request.setSkipErrorNoDescriptorsFound( true );
- request.setDependencies( dependencies );
+ request.setDependencies( new LinkedHashSet<>(
project.getArtifacts() ) );
Review comment:
There's nothing we can do here anymore. Could be a different ticket to
fix this inconsistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
