rmannibucau commented on pull request #526: URL: https://github.com/apache/maven/pull/526#issuecomment-902490370
Hi, Looks very promishing, congrats! I just have 2 small notes on the overall PR. 1. Since we got a positive vote on mvnd, did you think about making both converging to avoid to have two concurrent impl in the repository at the end? Think it is very doable. Can be worth a thread on the list but at the end I see it very beneficial for maven. 2. The only small technical note I would do right now is that jaxb should probably be replaced by standard maven xml parsing (xpp3 or alike), http client by wagon or other built-in dependencies - long story short no maven-core/pom.xml dep change. For the charset detection I wonder if something like https://github.com/apache/johnzon/blob/7751e96c4731a16a620a99e1165efac98db30566/johnzon-core/src/main/java/org/apache/johnzon/core/RFC4627AwareInputStreamReader.java#L86 would help and avoid the ENCODING_DETECTOR which looks a bit overkill for text file only. Hope it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
