michael-o commented on a change in pull request #122:
URL: https://github.com/apache/maven-scm/pull/122#discussion_r700420687
##########
File path:
maven-scm-providers/maven-scm-provider-perforce/src/test/java/org/apache/maven/scm/provider/perforce/command/unedit/PerforceUnEditConsumerTest.java
##########
@@ -59,7 +59,7 @@ public void testBadParse()
ConsumerUtils.consumeFile( testFile, consumer );
assertFalse( consumer.isSuccess() );
- assertTrue( consumer.getOutput().indexOf( ".classpath - file(s) not
opened on this client." ) == 0 );
+ assertEquals(0, consumer.getOutput().indexOf(".classpath - file(s) not
opened on this client."));
assertTrue( consumer.getOutput().indexOf( ".project - file(s) not
opened on this client." ) > 0 );
Review comment:
If this line uses true, why equals then?
##########
File path:
maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/test/java/org/apache/maven/scm/provider/cvslib/command/changelog/CvsChangeLogConsumerTest.java
##########
@@ -71,8 +71,7 @@ public void testParse()
for ( Iterator<ChangeSet> i = entries.iterator(); i.hasNext(); )
{
entry = i.next();
- assertTrue( "ChangeLogEntry erroneously picked up",
- entry.toString().indexOf( "ChangeLogEntry.java" ) ==
-1 );
+ assertEquals("ChangeLogEntry erroneously picked up", -1,
entry.toString().indexOf("ChangeLogEntry.java"));
Review comment:
Spaces lost
##########
File path:
maven-scm-providers/maven-scm-provider-starteam/src/test/java/org/apache/maven/scm/provider/starteam/command/remove/StarteamRemoveConsumerTest.java
##########
@@ -62,7 +62,7 @@ public void testParse()
assertTrue( entry.getPath().startsWith( "./" ) );
- assertTrue( entry.getStatus() == ScmFileStatus.DELETED );
+ assertSame(entry.getStatus(), ScmFileStatus.DELETED);
Review comment:
Spaces lost
##########
File path:
maven-scm-providers/maven-scm-provider-starteam/src/test/java/org/apache/maven/scm/provider/starteam/command/checkout/StarteamCheckOutConsumerTest.java
##########
@@ -64,7 +64,7 @@ private void testParse( File basedir )
{
assertTrue( entry.getPath().startsWith( "./" ) );
- assertTrue( entry.getStatus() == ScmFileStatus.CHECKED_OUT );
+ assertSame(entry.getStatus(), ScmFileStatus.CHECKED_OUT);
Review comment:
Spaces lost
##########
File path:
maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/mkdir/MkdirCommandTckTest.java
##########
@@ -45,7 +45,7 @@ public void testMkdirCommandMkdirLocal()
assertNotNull( result.getCreatedDirs() );
- assertTrue( "Directory should have been added.", 1 ==
result.getCreatedDirs().size() );
+ assertEquals("Directory should have been added.", 1,
result.getCreatedDirs().size());
Review comment:
Spaces lost
##########
File path:
maven-scm-providers/maven-scm-provider-starteam/src/test/java/org/apache/maven/scm/provider/starteam/command/checkin/StarteamCheckInConsumerTest.java
##########
@@ -62,7 +62,7 @@ public void testParse()
{
assertTrue( entry.getPath().startsWith( "./" ) );
- assertTrue( entry.getStatus() == ScmFileStatus.CHECKED_OUT );
+ assertSame(entry.getStatus(), ScmFileStatus.CHECKED_OUT);
Review comment:
Spaces lost
##########
File path:
maven-scm-providers/maven-scm-provider-starteam/src/test/java/org/apache/maven/scm/provider/starteam/command/add/StarteamAddConsumerTest.java
##########
@@ -65,7 +65,7 @@ public void testParse()
assertTrue( entry.getPath().startsWith( "./" ) );
- assertTrue( entry.getStatus() == ScmFileStatus.ADDED );
+ assertSame(entry.getStatus(), ScmFileStatus.ADDED);
Review comment:
Spaces lost
##########
File path:
maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/blame/BlameCommandTckTest.java
##########
@@ -88,7 +88,7 @@ public void testBlameCommand()
assertNotNull( "Expected not null revision", line.getRevision() );
assertNotNull( "Expected not null date", line.getDate() );
- assertTrue( "Expected another revision", !initialRevision.equals(
line.getRevision() ) );
+ assertFalse("Expected another revision",
initialRevision.equals(line.getRevision()));
Review comment:
Spaces lost
##########
File path:
maven-scm-providers/maven-scm-provider-starteam/src/test/java/org/apache/maven/scm/provider/starteam/command/changelog/StarteamChangeLogConsumerTest.java
##########
@@ -77,8 +77,7 @@ public void testNumberOfModifications()
for ( Iterator<ChangeSet> i = entries.iterator(); i.hasNext(); )
{
- assertTrue( "ChangeLogEntry erroneously picked up",
- i.next().toString().indexOf( "ChangeLogEntry.java" )
== -1 );
+ assertEquals("ChangeLogEntry erroneously picked up", -1,
i.next().toString().indexOf("ChangeLogEntry.java"));
Review comment:
Spaces lost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
