michael-o commented on a change in pull request #543:
URL: https://github.com/apache/maven/pull/543#discussion_r710429384
##########
File path:
maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
##########
@@ -190,8 +191,20 @@ public DependencyResolutionResult resolve(
DependencyResolutionRequest request )
{
if ( !child.getRelocations().isEmpty() )
{
- logger.warn( "The artifact " + child.getRelocations().get(
0 ) + " has been relocated to "
- + child.getDependency().getArtifact() );
+ org.eclipse.aether.artifact.Artifact artifact =
child.getRelocations().get( 0 );
+ StringBuilder message = new StringBuilder();
+ message.append( "The artifact " ).append( artifact )
Review comment:
The StringBuilder is redudant because constant string concat will be
turned into a StringBuilder internally anyway. SBs are useful for loops only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
