gnodet commented on a change in pull request #547:
URL: https://github.com/apache/maven/pull/547#discussion_r713761178
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java
##########
@@ -64,13 +64,13 @@ public LifecycleModuleBuilder(
MojoExecutor mojoExecutor,
BuilderCommon builderCommon,
ExecutionEventCatapult eventCatapult,
- ProjectExecutionListener projectExecutionListener,
+ List<ProjectExecutionListener> listeners,
Review comment:
AH, maybe the commits are misleading. The 3 last commits (Fix xxx)
should be merged into the "Use constructor injector" one, which would make
things more clear. Those are problems in the refactoring and should not be
reviewed per se, they only fix the previous commit. Let me fix that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
